Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate quotes #42

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Deduplicate quotes #42

merged 3 commits into from
Feb 14, 2021

Conversation

pscheid92
Copy link
Contributor

Resolves #41

  • Remove duplicates with different level of completeness
  • Harmonize and remove duplicates by using more common name Tony Robbins
  • Harmonize and remove duplicates by using more common name Lao Tzu

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #42 (d248b48) into master (51ceb09) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           27        27           
=========================================
  Hits            27        27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ceb09...d248b48. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pscheid92 superb PR! Removals are often better than additions and this is certainly the case. Thanks! 🙌

@nelsonic nelsonic merged commit 4476d65 into dwyl:master Feb 14, 2021
@pscheid92 pscheid92 deleted the 41-deduplicate-quotes branch February 24, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate quotes through different reasons
2 participants