Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate misattributed quote #46

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Deduplicate misattributed quote #46

merged 5 commits into from
Feb 17, 2021

Conversation

pscheid92
Copy link
Contributor

Closes #43

  • Remove quote misattributed to Abraham Lincoln
  • Attribute it to Dennis Gabor
  • Correct Peter Drucker quote accoring to book and Quote Investigator

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #46 (1a66cf3) into master (0b8d95b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           27        27           
=========================================
  Hits            27        27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b8d95b...1a66cf3. Read the comment docs.

quotes.json Outdated Show resolved Hide resolved
nelsonic
nelsonic previously approved these changes Feb 16, 2021
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pscheid92 great update. thanks very much! 🙌

quotes.json Outdated Show resolved Hide resolved
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iteles assigning this to you as I edited the url (source) of the Drucker quote so I'm no longer allowed to merge the PR. Please review+merge when you can. Thanks. ☀️

@nelsonic nelsonic requested a review from iteles February 16, 2021 09:08
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@iteles iteles merged commit 6dc6fce into dwyl:master Feb 17, 2021
@pscheid92 pscheid92 deleted the issue/43-deduplicate branch February 24, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplication through quote misattribution: Lincoln or Drucker
3 participants