Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Adding Dart package #97

Merged
merged 7 commits into from
May 19, 2023
Merged

[PR] Adding Dart package #97

merged 7 commits into from
May 19, 2023

Conversation

LuchoTurtle
Copy link
Member

closes #96

Adds Dart package, tests and changes to README.md.

Refactors CI to add Dart build check.

@LuchoTurtle LuchoTurtle added documentation Improvements or additions to documentation enhancement New feature or request in-progress labels May 17, 2023
@LuchoTurtle LuchoTurtle self-assigned this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #97 (325bae7) into main (6edd258) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           20        45   +25     
=========================================
+ Hits            20        45   +25     
Impacted Files Coverage Δ
lib/quotesy.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle
Copy link
Member Author

Haven't published the package because it needs to be approved first.
Once it is, I can follow https://dart.dev/tools/pub/publishing.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle looks Good. Thanks! 🙏
Please publish. 🚀

@nelsonic nelsonic merged commit 580f922 into main May 19, 2023
4 checks passed
@nelsonic nelsonic deleted the fix-#96 branch May 19, 2023 08:49
@LuchoTurtle
Copy link
Member Author

Done 🆗
https://pub.dev/packages/quotesy

@nelsonic
Copy link
Member

Thanks @LuchoTurtle 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feat: Create Dart Package for Flutter Example
2 participants