Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #17

Merged
merged 5 commits into from
Oct 7, 2021
Merged

update dependencies #17

merged 5 commits into from
Oct 7, 2021

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Oct 6, 2021

ref: #16
Looking at updating the tests

@SimonLab SimonLab self-assigned this Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@0837000). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage        ?   97.82%           
=======================================
  Files           ?        1           
  Lines           ?       46           
  Branches        ?        0           
=======================================
  Hits            ?       45           
  Misses          ?        1           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0837000...09769c7. Read the comment docs.

@nelsonic
Copy link
Member

nelsonic commented Oct 7, 2021

@SimonLab given that the purpose of this PR is complete (now that the auth app is working),
we could merge it and be back on track.

The Test stub/mock issue is separate: #18 💭

@SimonLab SimonLab marked this pull request as ready for review October 7, 2021 10:08
@SimonLab
Copy link
Member Author

SimonLab commented Oct 7, 2021

@nelsonic sounds good. I let you review merge it (even if you've been added more changes)

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab thanks for updating and tidying up this repo. 🎉

@nelsonic nelsonic merged commit 6db8dc6 into main Oct 7, 2021
@nelsonic nelsonic deleted the update-dependencies-#16 branch October 7, 2021 10:34
@nelsonic nelsonic mentioned this pull request Oct 7, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants