Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub CI + Dependabot issue #9 #10

Merged
merged 6 commits into from
May 9, 2022
Merged

Add GitHub CI + Dependabot issue #9 #10

merged 6 commits into from
May 9, 2022

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented May 1, 2022

Quick one. Fixes #9. Thanks. 🙏

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. labels May 1, 2022
@nelsonic nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation May 1, 2022
@codecov
Copy link

codecov bot commented May 1, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@65777f8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main       #10   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        16           
  Branches        ?         0           
========================================
  Hits            ?        16           
  Misses          ?         0           
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65777f8...f852af0. Read the comment docs.

@nelsonic nelsonic moved this from More ToDo ThanCanEver Be Done to Awaiting Feedback/Review in Nelson's List May 1, 2022
This was referenced May 1, 2022
Closed
Open
@nelsonic
Copy link
Member Author

nelsonic commented May 7, 2022

@SimonLab we are no longer using Travis CI so the badge in the README.md is Build Status 🤦‍♂️
This PR adds GitHub CI 🚀
Thanks for reviewing/merging. 🙏

SimonLab
SimonLab approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SimonLab SimonLab merged commit c976d79 into main May 9, 2022
Nelson's List automation moved this from Awaiting Feedback/Review to Done May 9, 2022
@SimonLab SimonLab deleted the add-github-ci-dependabot-issue-#9 branch May 9, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.
Projects
Nelson's List
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Travis-CI and Add GitHub CI (Workflow/Actions)
2 participants
@nelsonic @SimonLab