Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds stringify_map/1 #4

Merged
merged 5 commits into from
Oct 10, 2020
Merged

Adds stringify_map/1 #4

merged 5 commits into from
Oct 10, 2020

Conversation

vrcca
Copy link
Collaborator

@vrcca vrcca commented Oct 5, 2020

Implements #3

TODO

  • write tests for expected output
  • implement stringify_map/1 to stringify both Map and Struct data types
  • accept map of arbitrary depth/nesting and flatten it to a single level using flatten_map/1 function Flatten Map of Arbitrary Depth #2
  • publish new version of package to hex.pm

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           11        12    +1     
=========================================
+ Hits            11        12    +1     
Impacted Files Coverage Δ
lib/useful.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94eea74...39192c3. Read the comment docs.

lib/useful.ex Show resolved Hide resolved
lib/useful.ex Show resolved Hide resolved
@vrcca vrcca changed the title [WIP] Adds stringify_map/1 Adds stringify_map/1 Oct 9, 2020
@vrcca vrcca marked this pull request as ready for review October 9, 2020 17:00
@vrcca vrcca requested a review from nelsonic October 9, 2020 17:12
@nelsonic nelsonic self-assigned this Oct 9, 2020
@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Oct 10, 2020
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrcca implementation of stringify_map/1 looks good. 👍
If anything we should try and add more test cases in the future. 💡
Thanks for this PR. 🚀

@nelsonic nelsonic merged commit 704394e into dwyl:master Oct 10, 2020
@nelsonic
Copy link
Member

@vrcca new version published to Hex.pm: https://hex.pm/packages/useful/0.3.0 contains stringify_map/1 📦 :shipit:

@vrcca
Copy link
Collaborator Author

vrcca commented Oct 12, 2020

Thanks!

@vrcca
Copy link
Collaborator Author

vrcca commented Oct 12, 2020

@nelsonic Would you mind adding hacktoberfest-accepted to this PR? Or making the project hacktoberfest enabled?

@nelsonic
Copy link
Member

@nelsonic do I need to create a new label for that?
(I thought hacktoberfest automatically picked up on merged PRs ...)

@th0mas
Copy link

th0mas commented Oct 12, 2020

Seems not anymore, https://hacktoberfest.digitalocean.com/hacktoberfest-update

@vrcca
Copy link
Collaborator Author

vrcca commented Oct 12, 2020

They updated the rules recently to stop spammers from sending useless PRs.

@nelsonic
Copy link
Member

Thanks for confirming @th0mas 🙌

@nelsonic nelsonic added the hacktoberfest-accepted accepted for hacktoberfest label Oct 12, 2020
@nelsonic
Copy link
Member

Thanks again for the contribution. 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed hacktoberfest-accepted accepted for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants