Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/lib
directory./website
as needed.Description
As described in the linked issue, an error was spotted at the Dialog when using Jest and having to render this component. After some research, this problem was related to a nwsapi problem, which is a library used by Jest
jsdom
.So, to fix this, the aria-disabled selector was removed from the tabbable elements query at the
FocusLock
component. Apart from solving this problem, the change is motivated by the fact thataria-disabled
is a semantic attribute, i.e. it has no functionality on the component. Therefore, excluding elements with this attribute from the list of tabbable elements of the focus lock is unnecessary.Additional context
Issue: dperini/nwsapi#81
Closes #1586