Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added small table variant website doc #1831

Merged
merged 18 commits into from Feb 28, 2024
Merged

Added small table variant website doc #1831

merged 18 commits into from Feb 28, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Feb 19, 2024 •
edited

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Updated documentation with #1829 changes (wait for lib update)

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 21, 2024

Will be open once ActionCells (#1836) is merged

@raquelarrojo raquelarrojo self-requested a review February 21, 2024 15:19
@raquelarrojo raquelarrojo self-assigned this Feb 21, 2024
@Mil4n0r Mil4n0r marked this pull request as ready for review February 26, 2024 09:49
raquelarrojo
raquelarrojo requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@raquelarrojo raquelarrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should add in this PR the reduced table in specs.

  • Please push again package-lock with latest halstack-react version. It is giving conflicts because another PR with the same change was merged.

website/screens/components/resultset-table/code/examples/basicUsage.ts Outdated Show resolved Hide resolved
website/screens/components/resultset-table/code/examples/reduced.ts Show resolved Hide resolved
website/screens/components/resultset-table/code/examples/sortable.ts Outdated Show resolved Hide resolved
website/screens/components/table/code/TableCodePage.tsx Show resolved Hide resolved
website/screens/common/themes/advanced-theme.json Outdated Show resolved Hide resolved
website/screens/components/table/specs/TableSpecsPage.tsx Show resolved Hide resolved
@Mil4n0r Mil4n0r marked this pull request as draft February 27, 2024 09:12
@Mil4n0r Mil4n0r mentioned this pull request Feb 27, 2024
Merged
5 tasks
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 27, 2024 •
edited

Have to document the tokens from #1851.

@Mil4n0r Mil4n0r marked this pull request as ready for review February 28, 2024 10:29
@raquelarrojo raquelarrojo self-requested a review February 28, 2024 10:51
@raquelarrojo raquelarrojo merged commit 3959e76 into master Feb 28, 2024
4 checks passed
@raquelarrojo raquelarrojo deleted the Mil4n0r/small_table_variant-doc branch February 28, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jialecl Jialecl Jialecl left review comments

@raquelarrojo raquelarrojo raquelarrojo approved these changes

Assignees

@raquelarrojo raquelarrojo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mil4n0r @raquelarrojo @Jialecl