Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionsCell added to table and resultsetTable #1836

Merged
merged 8 commits into from Feb 21, 2024
Merged

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Feb 19, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Action Icon added to the table and resultsetTable to be used as a compound component.

Description
The component will be composed by the whole cell.
The action icon can also be a trigger for a dropdown, so the options prop was added to the compound component.

@Mil4n0r Mil4n0r self-requested a review February 19, 2024 13:32
@Mil4n0r Mil4n0r self-assigned this Feb 19, 2024
lib/src/resultset-table/ResultsetTable.stories.tsx Outdated Show resolved Hide resolved
lib/src/resultset-table/ResultsetTable.stories.tsx Outdated Show resolved Hide resolved
lib/src/resultset-table/ResultsetTable.stories.tsx Outdated Show resolved Hide resolved
lib/src/dropdown/Dropdown.tsx Show resolved Hide resolved
lib/src/common/variables.ts Show resolved Hide resolved
lib/src/common/variables.ts Show resolved Hide resolved
@Mil4n0r Mil4n0r merged commit f18281d into master Feb 21, 2024
4 checks passed
@Mil4n0r Mil4n0r deleted the jialecl-actionsCell branch February 21, 2024 14:04
@Jialecl Jialecl restored the jialecl-actionsCell branch February 21, 2024 15:17
@Jialecl Jialecl mentioned this pull request Feb 21, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants