Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update main cli with TS defs. #506

Merged
merged 20 commits into from
May 16, 2022
Merged

feat!: update main cli with TS defs. #506

merged 20 commits into from
May 16, 2022

Conversation

richburdon
Copy link
Member

@richburdon richburdon commented May 11, 2022 •
edited
Loading

  • TS defs
  • removed bind/call from export methods main.ts
  • removed shouldIniti/Destroy booleans (just test function)
  • changed extension.yml to dx.yml
  • sorted JSON config files
  • removed deep imports (e.g., foo/bar)
  • moved generated extensions file to gen
  • added info command and dev.sh script (see README)

ISSUES:

  • important to nail down and use consistently types defined in cli-core/types.ts; in particular:
    • protobuf definition for dx.yml
    • input and return types for cli-factory (esp. info)
    • ExtensionManager (esp. add info)
    • reconcile command, commands, modules, etc. (single variant)

@egorgripasov egorgripasov changed the title feat: update main cli with TS defs. feat!: update main cli with TS defs. May 16, 2022
@egorgripasov egorgripasov merged commit 5022f9c into main May 16, 2022
@egorgripasov egorgripasov deleted the burdon/refresh branch May 16, 2022 17:50
@dxos-bot dxos-bot mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorgripasov egorgripasov Awaiting requested review from egorgripasov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richburdon @egorgripasov