Migrate to php8.3 #591
Merged
Migrate to php8.3 #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snim2
force-pushed
the
chore/migrate-to-php8.3
branch
from
a180f38
to
fbb13d0
Compare
patdel0
force-pushed
the
chore/migrate-to-php8.3
branch
4 times, most recently
from
ca3a2d5
to
635f26a
Compare
snim2
commented
Jun 21, 2024
mattymaxwell
approved these changes
Jun 21, 2024
This is due to 8.2 deprecating dynamically declared properties. https://www.php.net/manual/en/language.oop5.properties.php
The latest version of WP_Mock changed the name of the function ::wpFunction to ::userFunction. This commit makes that change in the tests as well. https://github.com/10up/wp_mock/pull/50/files
patdel0
force-pushed
the
chore/migrate-to-php8.3
branch
from
635f26a
to
0d94d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the dependencies to PHP 8.2 and converts Peridot tests to Kahlan, due to compatibility issues.