Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert all icons to mdi icons #1499

Merged
merged 2 commits into from
Mar 14, 2024
Merged

convert all icons to mdi icons #1499

merged 2 commits into from
Mar 14, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Mar 14, 2024

Gets rid of fontawesome icons. Saves about 50kb of CSS and a bunch more from not needing to serve 2 icon sets.

before

...
dist/assets/fa-regular-400-xs7tW3kq.woff2                     13.22 kB
dist/assets/fa-regular-400-xZzHCT3Y.woff                      16.28 kB
dist/assets/fa-regular-400-9b8-lgcZ.ttf                       33.74 kB
dist/assets/fa-regular-400-YU8LU_ML.eot                       34.03 kB
dist/assets/fa-brands-400-FMZSC47y.woff2                      76.74 kB
dist/assets/fa-solid-900-VLMCYEaC.woff2                       78.27 kB
dist/assets/fa-brands-400-hCWwoNeu.woff                       89.99 kB
dist/assets/fa-solid-900-zl4AgKZg.woff                       101.65 kB
dist/assets/fa-brands-400-kmDagW_7.ttf                       133.99 kB
dist/assets/fa-brands-400-55D35N6K.eot                       134.29 kB
dist/assets/fa-regular-400-IMI_D8av.svg                      144.71 kB │ gzip:  37.36 kB
dist/assets/fa-solid-900-JsbsZwRG.ttf                        202.74 kB
dist/assets/fa-solid-900-egMaa32_.eot                        203.03 kB
dist/assets/materialdesignicons-webfont-PG5eMg0i.woff2       224.35 kB
dist/assets/materialdesignicons-webfont-oMeLOwbK.woff        319.31 kB
dist/assets/materialdesignicons-webfont-go9nydPi.ttf         662.93 kB
dist/assets/materialdesignicons-webfont-OWtXZZ3R.eot         663.15 kB
dist/assets/fa-brands-400-HB9TICmz.svg                       747.93 kB │ gzip: 255.18 kB
dist/assets/fa-solid-900-eGWe5Hz8.svg                        918.99 kB │ gzip: 257.13 kB
...
dist/assets/index-np6k4Ilm.css                               645.61 kB │ gzip:  97.41 kB
...

after

...
dist/assets/materialdesignicons-webfont-PG5eMg0i.woff2       224.35 kB
dist/assets/materialdesignicons-webfont-oMeLOwbK.woff        319.31 kB
dist/assets/materialdesignicons-webfont-go9nydPi.ttf         662.93 kB
dist/assets/materialdesignicons-webfont-OWtXZZ3R.eot         663.15 kB
...
dist/assets/index-bhiFH0HT.css                               592.00 kB │ gzip:  84.58 kB
...

Copy link
Contributor

coderabbitai bot commented Mar 14, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 56.1673%. Comparing base (101f40e) to head (b29a68b).
Report is 1 commits behind head on master.

Files Patch % Lines
client/src/components/UserList.vue 30.0000% 7 Missing ⚠️
client/src/App.vue 0.0000% 5 Missing ⚠️
client/src/components/ToastNotification.vue 0.0000% 3 Missing ⚠️
client/src/views/RoomList.vue 0.0000% 3 Missing ⚠️
client/src/components/navbar/NavCreateRoom.vue 0.0000% 2 Missing ⚠️
client/src/views/Home.vue 0.0000% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1499        +/-   ##
================================================
+ Coverage   56.1352%   56.1673%   +0.0320%     
================================================
  Files           163        163                
  Lines         24840      24865        +25     
  Branches       1432       1435         +3     
================================================
+ Hits          13944      13966        +22     
- Misses        10842      10845         +3     
  Partials         54         54                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 14, 2024

Passing run #1302 ↗︎

0 52 1 0 Flakiness 0

Details:

Merge b29a68b into 6acf2dc...
Project: OpenTogetherTube Commit: 886bf27fba ℹ️
Status: Passed Duration: 02:08 💡
Started: Mar 14, 2024 10:57 PM Ended: Mar 14, 2024 10:59 PM

Review all test suite changes for PR #1499 ↗︎

@dyc3 dyc3 merged commit 4f38e0b into master Mar 14, 2024
19 of 21 checks passed
@dyc3 dyc3 deleted the mdi-icons branch March 14, 2024 23:31
Copy link

cypress bot commented Mar 14, 2024

Passing run #1303 ↗︎

0 75 1 0 Flakiness 0

Details:

convert all icons to mdi icons (#1499)
Project: OpenTogetherTube Commit: 4f38e0b9e2
Status: Passed Duration: 03:17 💡
Started: Mar 14, 2024 11:33 PM Ended: Mar 14, 2024 11:36 PM

Review all test suite changes for PR #1499 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant