-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert all icons to mdi icons #1499
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1499 +/- ##
================================================
+ Coverage 56.1352% 56.1673% +0.0320%
================================================
Files 163 163
Lines 24840 24865 +25
Branches 1432 1435 +3
================================================
+ Hits 13944 13966 +22
- Misses 10842 10845 +3
Partials 54 54 ☔ View full report in Codecov by Sentry. |
Passing run #1302 ↗︎Details:
Review all test suite changes for PR #1499 ↗︎ |
Passing run #1303 ↗︎Details:
Review all test suite changes for PR #1499 ↗︎ |
Gets rid of fontawesome icons. Saves about 50kb of CSS and a bunch more from not needing to serve 2 icon sets.
before
after