Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trade action behavior on a specific account #36

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Fix trade action behavior on a specific account #36

merged 2 commits into from
Jun 13, 2018

Conversation

alexmi1
Copy link
Contributor

@alexmi1 alexmi1 commented Jun 12, 2018

Fix #35

@alexmi1 alexmi1 changed the title Fix #35 Fix trade action behavior on a specific account Jun 12, 2018
@dyc3 dyc3 added the bug label Jun 12, 2018
@dyc3 dyc3 self-requested a review June 12, 2018 15:35
Program.cs Outdated
@@ -538,11 +538,10 @@ static void Trade(string user = "", string passkey = "")

foreach (var account in SteamGuardAccounts)
{
if (user != "")
if (!string.Equals(account.AccountName, user, StringComparison.CurrentCultureIgnoreCase))
break;
Copy link
Owner

@dyc3 dyc3 Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just changing this break to a continue would suffice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work too, it's up to you. I took a look at how accept-all was implemented and just did something similar because I personally don't like using continue unless necessary.

Copy link
Owner

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll release a new build when I get a chance.

@dyc3 dyc3 merged commit 8815121 into dyc3:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants