This repository has been archived by the owner on Sep 27, 2022. It is now read-only.
Add ExchangeWrappers for OasisDex #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanChou
force-pushed
the
bc_ew
branch
4 times, most recently
from
7da5f1e
to
71c2f84
Compare
Pull Request Test Coverage Report for Build 8174
💛 - Coveralls |
BrendanChou
changed the title
BrendanChou
changed the title
BrendanChou
force-pushed
the
bc_ew
branch
4 times, most recently
from
e2be98d
to
a83e04d
Compare
BrendanChou
force-pushed
the
bc_ew
branch
2 times, most recently
from
67024b3
to
1242040
Compare
BrendanChou
force-pushed
the
bc_ew
branch
4 times, most recently
from
d89dd43
to
10a2380
Compare
BrendanChou
force-pushed
the
bc_ew
branch
3 times, most recently
from
245a16a
to
5feefa3
Compare
BrendanChou
changed the title
BrendanChou
force-pushed
the
bc_ew
branch
4 times, most recently
from
caafccf
to
516e92f
Compare
AntonioJuliano
suggested changes
Oct 3, 2018
contracts/margin/external/exchangewrappers/MatchingMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/MatchingMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/MatchingMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/MatchingMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/MatchingMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/MatchingMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/SimpleMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/SimpleMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/SimpleMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
contracts/margin/external/exchangewrappers/SimpleMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
BrendanChou
changed the title
BrendanChou
force-pushed
the
bc_ew
branch
2 times, most recently
from
c0fcaa4
to
19fd2d3
Compare
BrendanChou
force-pushed
the
bc_ew
branch
3 times, most recently
from
e76521c
to
359ce03
Compare
AntonioJuliano
suggested changes
Oct 12, 2018
contracts/margin/external/exchangewrappers/MatchingMarketExchangeWrapper.sol
Outdated
Show resolved
Hide resolved
| pure | ||
| returns (uint256, uint256) | ||
| { | ||
| uint256 takerAmount = 0; |
There was a problem hiding this comment.
Call these takerAmountRatio + makerAmountRatio to be consistent
| * contracts to trade using a specific offer. Since any MatchingMarket is also a SimpleMarket, this | ||
| * ExchangeWrapper can also be used for any MatchingMarket. | ||
| */ | ||
| contract SimpleMarketExchangeWrapper is |
There was a problem hiding this comment.
I think the names of these contracts should have oasis in them somewhere. Otherwise it's super generally named
There was a problem hiding this comment.
Will also change to OasisV1 to differentiate from their V2 release
AntonioJuliano
approved these changes
Oct 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #368