Fix IsIsolatedPerpetual function orientation

Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
dydxprotocol · Apr 23, 2024 · a94c952 · a94c952
1 parent 30b926d
commit a94c952
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/protocol/x/perpetuals/keeper/perpetual.go b/protocol/x/perpetuals/keeper/perpetual.go
@@ -33,8 +33,12 @@ import (
 )
 
 func (k Keeper) IsIsolatedPerpetual(ctx sdk.Context, perpetualId uint32) (bool, error) {
-	insuranceFundName, err := k.GetInsuranceFundName(ctx, perpetualId)
-	return insuranceFundName == types.InsuranceFundName, err
+	perpetual, err := k.GetPerpetual(ctx, perpetualId)
+	if err != nil {
+		return false, err
+	}
+
+	return perpetual.Params.MarketType == types.PerpetualMarketType_PERPETUAL_MARKET_TYPE_ISOLATED, nil
 }
 
 // GetInsuranceFundName returns the name of the insurance fund account for a given perpetual.

diff --git a/protocol/x/subaccounts/keeper/negative_tnc_subaccount.go b/protocol/x/subaccounts/keeper/negative_tnc_subaccount.go
@@ -112,9 +112,9 @@ func (k Keeper) getNegativeTncSubaccountStoreSuffix(
 		return "", err
 	}
 	if isIsolated {
-		return types.CrossCollateralSuffix, nil
-	} else {
 		return lib.UintToString(perpetualId), nil
+	} else {
+		return types.CrossCollateralSuffix, nil
 	}
 }