Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-852] Re-add Rosetta cmd #1002

Merged
merged 1 commit into from Jan 23, 2024
Merged

[CORE-852] Re-add Rosetta cmd #1002

merged 1 commit into from Jan 23, 2024

Conversation

lcwik
Copy link
Contributor

@lcwik lcwik commented Jan 22, 2024

Changelist

[CORE-852] Re-add Rosetta cmd

Example output from cmd line:

protocol % ./build/dydxprotocold rosetta --help
spin up a rosetta server

Usage:
  dydxprotocold rosetta [flags]

Flags:
      --addr string                the address rosetta will bind to (default ":8080")
      --blockchain string          the blockchain type (default "app")
      --denom-to-suggest string    default denom for fee suggestion (default "uatom")
      --enable-fee-suggestion      enable default fee suggestion
      --gas-to-suggest int         default gas for fee suggestion (default 200000)
      --grpc string                the app gRPC endpoint (default "localhost:9090")
      --grpc-types-server string   the app gRPC Server endpoint for proto messages types and reflection
  -h, --help                       help for rosetta
      --network string             the network name (default "network")
      --offline                    run rosetta only with construction API
      --plugin string              plugin folder name (default "cosmos-hub")
      --prices-to-suggest string   default prices for fee suggestion (default "1uatom,1stake")
      --retries int                the number of retries that will be done before quitting (default 5)
      --tendermint string          the CometBFT rpc endpoint, without tcp:// (default "localhost:26657")

Global Flags:
      --home string         directory for config and data (default "/Users/lcwik/.dydxprotocol")
      --log_format string   The logging format (json|plain) (default "plain")
      --log_level string    The logging level (trace|debug|info|warn|error|fatal|panic|disabled or '*:<level>,<key>:<level>') (default "info")
      --log_no_color        Disable colored logs
      --trace               print out full stack trace on errors

Test Plan

Manually tested.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Copy link

coderabbitai bot commented Jan 22, 2024

Walkthrough

The update to the codebase introduces the rosettaCmd package and enhances the initRootCmd function by integrating the RosettaCommand from the rosettaCmd package. This change suggests that the application is now incorporating Rosetta API functionalities, which is a standard designed to simplify the integration of different blockchains into crypto applications.

Changes

Files Change Summary
protocol/.../root.go Added rosettaCmd package and updated initRootCmd to include rosettaCmd.RosettaCommand with different arguments.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4357938 and edc345b.
Files ignored due to path filters (2)
  • protocol/go.mod is excluded by: !**/*.mod
  • protocol/go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • protocol/cmd/dydxprotocold/cmd/root.go (2 hunks)
Additional comments: 2
protocol/cmd/dydxprotocold/cmd/root.go (2)
  • 40-40: Import of rosettaCmd package added.
  • 228-228: Integration of RosettaCommand into initRootCmd.

Example output from cmd line:
```
protocol % ./build/dydxprotocold rosetta --help
spin up a rosetta server

Usage:
  dydxprotocold rosetta [flags]

Flags:
      --addr string                the address rosetta will bind to (default ":8080")
      --blockchain string          the blockchain type (default "app")
      --denom-to-suggest string    default denom for fee suggestion (default "uatom")
      --enable-fee-suggestion      enable default fee suggestion
      --gas-to-suggest int         default gas for fee suggestion (default 200000)
      --grpc string                the app gRPC endpoint (default "localhost:9090")
      --grpc-types-server string   the app gRPC Server endpoint for proto messages types and reflection
  -h, --help                       help for rosetta
      --network string             the network name (default "network")
      --offline                    run rosetta only with construction API
      --plugin string              plugin folder name (default "cosmos-hub")
      --prices-to-suggest string   default prices for fee suggestion (default "1uatom,1stake")
      --retries int                the number of retries that will be done before quitting (default 5)
      --tendermint string          the CometBFT rpc endpoint, without tcp:// (default "localhost:26657")

Global Flags:
      --home string         directory for config and data (default "/Users/lcwik/.dydxprotocol")
      --log_format string   The logging format (json|plain) (default "plain")
      --log_level string    The logging level (trace|debug|info|warn|error|fatal|panic|disabled or '*:<level>,<key>:<level>') (default "info")
      --log_no_color        Disable colored logs
      --trace               print out full stack trace on errors
```
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4357938 and 745f6fb.
Files ignored due to path filters (2)
  • protocol/go.mod is excluded by: !**/*.mod
  • protocol/go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • protocol/cmd/dydxprotocold/cmd/root.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • protocol/cmd/dydxprotocold/cmd/root.go

@lcwik lcwik merged commit 0f87843 into main Jan 23, 2024
17 checks passed
@lcwik lcwik deleted the lukecore852.2 branch January 23, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants