-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTE-248] Update LiquidityTierUpsertEvent to add OI caps #1242
Conversation
WalkthroughThe updates encompass the introduction of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
02c029b
to
bc062cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
protocol/indexer/events/events.pb.go
is excluded by:!**/*.pb.go
Files selected for processing (5)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts (6 hunks)
- proto/dydxprotocol/indexer/events/events.proto (1 hunks)
- protocol/indexer/events/liquidity_tier.go (1 hunks)
- protocol/indexer/events/liquidity_tier_test.go (1 hunks)
- protocol/x/perpetuals/keeper/perpetual.go (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts
- proto/dydxprotocol/indexer/events/events.proto
- protocol/indexer/events/liquidity_tier.go
- protocol/indexer/events/liquidity_tier_test.go
- protocol/x/perpetuals/keeper/perpetual.go
bc062cc
to
076270e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
protocol/indexer/events/events.pb.go
is excluded by:!**/*.pb.go
Files selected for processing (6)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts (6 hunks)
- indexer/services/ender/tests/helpers/constants.ts (1 hunks)
- proto/dydxprotocol/indexer/events/events.proto (1 hunks)
- protocol/indexer/events/liquidity_tier.go (1 hunks)
- protocol/indexer/events/liquidity_tier_test.go (1 hunks)
- protocol/x/perpetuals/keeper/perpetual.go (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts
- proto/dydxprotocol/indexer/events/events.proto
- protocol/indexer/events/liquidity_tier.go
- protocol/indexer/events/liquidity_tier_test.go
- protocol/x/perpetuals/keeper/perpetual.go
openInterestLowerCap: 0, | ||
openInterestUpperCap: 10000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of openInterestLowerCap
and openInterestUpperCap
to defaultLiquidityTierUpsertEvent
aligns with the PR's objectives. It's crucial to ensure that the tests using this constant are updated to reflect these new fields. Additionally, consider adding tests that specifically examine the system's behavior when the open interest is at, below, or above these caps to ensure comprehensive coverage.
Would you like assistance in creating these additional tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- indexer/services/ender/tests/helpers/constants.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- indexer/services/ender/tests/helpers/constants.ts
Changelist
Added caps to liquidity tier upsert event
Test Plan
updated test to account for new fields
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.