Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cli to convert module name to address #1462

Merged
merged 6 commits into from
May 3, 2024

Conversation

shrenujb
Copy link
Contributor

@shrenujb shrenujb commented May 3, 2024

Changelist

Add a cli to convert a module name string to the dydx address. This will be useful to determine addresses for different module accounts for isolated markets

Test Plan

Existing tests

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Added a command to convert module names to addresses, enhancing user interaction with the protocol's CLI.
  • Tests

    • Implemented tests to ensure the reliability of the new module name to address conversion feature.

Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
Copy link

coderabbitai bot commented May 3, 2024

Walkthrough

The recent updates introduce a new command, CmdModuleNameToAddress, across several files in the project. This command facilitates the conversion of a module name to its corresponding address. Changes include the addition of this command in CLI query functionalities, the implementation of the conversion logic, and the inclusion of tests to ensure the command's accuracy and reliability.

Changes

File Path Change Summary
.../cli/query.go Added CmdModuleNameToAddress() to GetQueryCmd function.
.../cli/query_perpetual.go Introduced new CLI command CmdModuleNameToAddress for module name to address conversion.
.../cli/query_perpetual_test.go Added test TestCmdModuleNameToAddress to verify module name to address mapping.
.../cmd/root.go, .../cmd/root_test.go Implemented and tested new function CmdModuleNameToAddress in root command setup.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 76094e3 and 084e201.
Files selected for processing (1)
  • protocol/cmd/dydxprotocold/cmd/root.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • protocol/cmd/dydxprotocold/cmd/root.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

protocol/x/perpetuals/client/cli/query_perpetual_test.go Outdated Show resolved Hide resolved
protocol/cmd/dydxprotocold/cmd/root.go Outdated Show resolved Hide resolved
Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
@shrenujb shrenujb merged commit 648bb3c into main May 3, 2024
17 checks passed
@shrenujb shrenujb deleted the sbansal/cli-for-module-name-to-address branch May 3, 2024 20:39
jonfung-dydx pushed a commit that referenced this pull request May 6, 2024
Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants