Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-538] Add 4.0.0 upgrade handler for Cosmos 0.47 -> 0.50 upgrade handler. #918

Merged
merged 3 commits into from
Jan 6, 2024
Merged

[CORE-538] Add 4.0.0 upgrade handler for Cosmos 0.47 -> 0.50 upgrade handler. #918

merged 3 commits into from
Jan 6, 2024

Commits on Jan 5, 2024

  1. [CORE-538] Add 4.0.0 upgrade handler for Cosmos 0.47 -> 0.50 upgrade … 

    …handler.

This adds the 3.0.0-dev0 binaries statically and fixes the IBC parameter space to map the old parameters to the new ones allowing for the IBC upgrade as per the upgrade guide
(https://github.com/cosmos/ibc-go/blob/e3e8f343d05d3f7dfd958877562bca3aff89b758/docs/docs/05-migrations/11-v7-to-v8.md#params-migration) and this sample
(https://github.com/cosmos/ibc-go/blob/v8.0.0/testing/simapp/app.go#L1007-L1012).

It turns out that the upgrade handlers are already routable and the existing logic could be removed safely without requiring a replacement.

Decided to allow for using the existing upgrade messages to allow the maximum flexibility when doing the release and punted deprecation till once users are on Cosmos 0.50 for some time.

Finally, delete the 3.0.0 upgrade handler.
    @lcwik
    lcwik committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    2d52be9 View commit details
    Browse the repository at this point in the history

  2. Add comment.

    @lcwik
    lcwik committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    463a069 View commit details
    Browse the repository at this point in the history

  3. Re-add deleted 3.0.0 upgrade handler

    @lcwik
    lcwik committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    2192e87 View commit details
    Browse the repository at this point in the history