Fix withdrawal gating double usage of metrics name for two different types of counters.

[lcwik]

Changelist

Fix withdrawal gating double usage of metrics name for two different types of counters.

Test Plan

Manually test on persistent environment.

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[coderabbitai]

Walkthrough

The update involves the introduction of a new metric key and the renaming of an existing metric to reflect its function more accurately. The focus is on tracking the latency of a specific process, indicated by the addition of Latency to the metric's name. This change is applied to a function within the code, ensuring that the metric name aligns with the new key.

Changes

File Path	Change Summary
.../metrics/metric_keys.go	Introduced new metric key GateWithdrawalsIfNegativeTncSubaccountSeen and renamed existing key by adding Latency.
.../clob/keeper/deleveraging.go	Updated metric name within GateWithdrawalsIfNegativeTncSubaccountSeen function to GateWithdrawalsIfNegativeTncSubaccountSeenLatency.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 76068c9 and 396fb12.

Files selected for processing (2)

• protocol/lib/metrics/metric_keys.go (2 hunks)
• protocol/x/clob/keeper/deleveraging.go (1 hunks)

Additional comments: 3

protocol/lib/metrics/metric_keys.go (2)

• 24-24: The new metric key GateWithdrawalsIfNegativeTncSubaccountSeen follows the guidelines provided for metric keys naming conventions.
• 54-54: The new metric key GateWithdrawalsIfNegativeTncSubaccountSeenLatency is correctly named with a suffix indicating the unit of measurement (Latency), adhering to the guidelines.

protocol/x/clob/keeper/deleveraging.go (1)

• 198-198: The metric name in the GateWithdrawalsIfNegativeTncSubaccountSeen function has been correctly updated to GateWithdrawalsIfNegativeTncSubaccountSeenLatency, reflecting the changes made in the metric_keys.go file.