[CORE-538] Fix CLI tests to correctly generate module address

[lcwik]

Changelist

[CORE-538] Fix CLI tests to correctly generate module address.

Incorrectly converted how we generate module address during Cosmos 0.50 upgrade. This was the only case of where I swapped module address generation with using the signing context erroneously.

Test Plan

Re-enabled existing tests.

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[linear]

CORE-538 Upgrade to Cosmos 0.50.0 (when available) and CometBFT 0.38.0

[coderabbitai]

Walkthrough

The codebase has been updated to streamline the handling of account addresses and improve the testing of command-line interfaces (CLI). A dependency on an external package for address generation has been replaced by an internal module function, simplifying the address calculation process. Additionally, previously skipped tests in the CLI related to bank balance issues in the subaccounts module have now been re-enabled, suggesting that the underlying problems have been addressed.

Changes

File(s)	Change Summary
protocol/testutil/bank/bank_helpers.go	Replaced address calculation logic with authtypes.NewModuleAddress.
protocol/x/clob/client/cli/.../cancel_order_cli_test.go, protocol/x/clob/client/cli/.../liquidations_cli_test.go, protocol/x/clob/client/cli/.../place_order_cli_test.go	Removed s.T().Skip calls, indicating resolved bank balance issues for subaccounts module in CLI tests.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 62fc6a4 and 8356946.

Files selected for processing (4)

• protocol/testutil/bank/bank_helpers.go (2 hunks)
• protocol/x/clob/client/cli/cancel_order_cli_test.go (2 hunks)
• protocol/x/clob/client/cli/liquidations_cli_test.go (1 hunks)
• protocol/x/clob/client/cli/place_order_cli_test.go (1 hunks)

Files skipped from review due to trivial changes (2)

• protocol/x/clob/client/cli/cancel_order_cli_test.go
• protocol/x/clob/client/cli/place_order_cli_test.go

Additional comments: 3

protocol/testutil/bank/bank_helpers.go (2)

• 11-11: Import of authtypes package is correct and necessary for the use of NewModuleAddress.
• 28-28: The replacement of the address calculation logic with authtypes.NewModuleAddress(moduleName) is correct and aligns with the PR objectives.

protocol/x/clob/client/cli/liquidations_cli_test.go (1)

• 54-59: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [1-1]

Re-enabling of the TestLiquidationOrderIntegrationTestSuite function is consistent with the PR objectives, which state that previously skipped tests are now operational.