-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish transfer guide #226
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
## Determining parameters | ||
|
||
* Asset | ||
Asset ID can be fetched using the `/dydxprotocol/assets/asset` endpoint. [Example](https://dydx-api.lavenderfive.com:443/dydxprotocol/assets/asset) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the way the Example link is formatted makes this a little bit unclear -- it could read "Example Collateral token (USCD)..."
Suggest putting the Example links in parentheses
I took a quick look at docs pages on the same level and it doesn't seem like this formatting is standard, so I think it's worth changing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@@ -0,0 +1,214 @@ | |||
import { Tab, Tabs } from "nextra-theme-docs"; | |||
|
|||
# How to transfer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest something more descriptive as a nav item, like "Transfer tokens between accounts" (or just How to transfer tokens)
nit: the nav item is title-cased "How to Transfer." It's not totally consistent but looks like most these pages are not, so I'd make both the header and the nav item sentence-case, "How to transfer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done! I think (How to transfer -> How to transfer tokens between accounts
)
Co-authored-by: zach <zc0311@gmail.com>
Merging but feel free to continue to leave comments, i can come back to address! |
Looks good to me! |
No description provided.