Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish transfer guide #226

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Polish transfer guide #226

merged 5 commits into from
Jun 20, 2024

Conversation

jiajames
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-teacher ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:32pm

## Determining parameters

* Asset
Asset ID can be fetched using the `/dydxprotocol/assets/asset` endpoint. [Example](https://dydx-api.lavenderfive.com:443/dydxprotocol/assets/asset)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the way the Example link is formatted makes this a little bit unclear -- it could read "Example Collateral token (USCD)..."

Suggest putting the Example links in parentheses

I took a quick look at docs pages on the same level and it doesn't seem like this formatting is standard, so I think it's worth changing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@@ -0,0 +1,214 @@
import { Tab, Tabs } from "nextra-theme-docs";

# How to transfer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest something more descriptive as a nav item, like "Transfer tokens between accounts" (or just How to transfer tokens)

nit: the nav item is title-cased "How to Transfer." It's not totally consistent but looks like most these pages are not, so I'd make both the header and the nav item sentence-case, "How to transfer"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! I think (How to transfer -> How to transfer tokens between accounts)

jiajames and others added 2 commits June 20, 2024 16:08
@jiajames
Copy link
Contributor Author

Merging but feel free to continue to leave comments, i can come back to address!

@jiajames jiajames merged commit c62c1d3 into main Jun 20, 2024
4 checks passed
@jiajames jiajames deleted the jj/transfer-guide-polish branch June 20, 2024 20:40
@zachfc
Copy link
Contributor

zachfc commented Jun 20, 2024

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants