Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reliability): orders transaction queue -- bump packages #392

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

aforaleka
Copy link
Collaborator

@aforaleka aforaleka commented Mar 20, 2024

Context: Traders have encountered an issue where canceling stateful orders can be unreliable. Root cause appears to be broadcast errors related to sequence numbers when placing or canceling stateful orders in rapid succession.

To address this, a transaction queue is added in abacus for placing and canceling stateful orders, so that the transactions are done sequentially but without blocking UI interactions.

In v4-clients, placing and canceling long term and conditional orders now default to use Method.BroadcastTxCommit. Thus the action will only complete after tx has been fully committed.

To test:

  1. Cancel multiple stateful orders in quick succession - observe that they should all be eventually canceled (at least not fail with broadcast errors), instead of being stuck in loading state / no action.
  2. Place and cancel multiple orders in quick succession, can be either short term, long term, or conditional. They should not fail with broadcast errors.

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 8:36pm
v4-testnet ✅ Ready (Inspect) Visit Preview Mar 20, 2024 8:36pm

@aforaleka aforaleka changed the title feat: orders transaction queue -- bump abacus and v4-clients package feat(reliability): orders transaction queue -- bump packages Mar 20, 2024
@aforaleka aforaleka merged commit a82842b into main Mar 21, 2024
8 checks passed
@aforaleka aforaleka deleted the bump-abacus-tx-queue branch April 22, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants