chore: standardize date/number formatting #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tyleroooo
changed the title
jaredvu
reviewed
Jun 25, 2024
jaredvu
reviewed
Jun 25, 2024
| @@ -100,7 +98,7 @@ export const OrderDetailsDialog = ({ | |||
| ); | |||
|
|
|||
| const renderOrderTime = ({ timeInMs }: { timeInMs: Nullable<number> }) => | |||
| timeInMs ? <time>{relativeTimeString({ timeInMs, selectedLocale })}</time> : '-'; | |||
| timeInMs ? <Output type={OutputType.DateTime} value={timeInMs} /> : '-'; | |||
There was a problem hiding this comment.
I don't think we need to use a ternary here since the <Output> component handles timeInMs = null by rendering -
There was a problem hiding this comment.
As far as I can tell that is only true for numbers. Dates and relative dates bail early and return null if things aren't quite right I think.
We can make dates behave similarly, I'd just do a quick audit to make sure it doesn't break any existing behavior.
jaredvu
approved these changes
Jun 26, 2024
This was referenced Jun 27, 2024
DavideSegullo
added a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 28, 2024
commit dc02b27 Author: yujin512 <yujin@dydx.exchange> Date: Thu Jun 27 16:30:17 2024 -0400 feat: add blast and metadata (dydxprotocol#738) Co-authored-by: jaredvu <jaredvu@gmail.com> commit cf2c9f2 Author: moo-onthelawn <70078372+moo-onthelawn@users.noreply.github.com> Date: Thu Jun 27 13:09:58 2024 -0400 chore(memo): clean up memo flag + flip staking to be true in mainnet (dydxprotocol#741) commit 27115fd Author: Jeremy Lee <37092291+yogurtandjam@users.noreply.github.com> Date: Wed Jun 26 20:11:42 2024 -0400 chore: observability for skip migration [OTE-432] (dydxprotocol#737) commit b85c1eb Author: moo-onthelawn <70078372+moo-onthelawn@users.noreply.github.com> Date: Wed Jun 26 19:08:56 2024 -0400 chore(staking): update faq to have see more here link to published help article (dydxprotocol#735) commit b10abde Author: tyleroooo <tyler@dydx.exchange> Date: Wed Jun 26 18:01:08 2024 -0400 chore: standardize date/number formatting (dydxprotocol#676) commit 23a4bd2 Author: yang-dydx <117109716+yang-dydx@users.noreply.github.com> Date: Wed Jun 26 14:30:08 2024 -0700 chore(staking): add default validator as part of stake transaction event (dydxprotocol#736) commit 83908b3 Author: tyleroooo <tyler@dydx.exchange> Date: Wed Jun 26 17:15:34 2024 -0400 fix: back to linear scale orderbook bars (dydxprotocol#734) commit b5ef243 Author: moo-onthelawn <70078372+moo-onthelawn@users.noreply.github.com> Date: Wed Jun 26 16:40:17 2024 -0400 fix(staking): fix chart not loading properly (dydxprotocol#733) commit 22125a6 Author: aleka <aforaleka@gmail.com> Date: Wed Jun 26 13:39:41 2024 -0400 chore: another pass for the markets panels padding (dydxprotocol#732) commit 131292e Author: moo-onthelawn <70078372+moo-onthelawn@users.noreply.github.com> Date: Wed Jun 26 12:18:25 2024 -0400 fix(staking): update button styling on tokens page + add error if wallet balance < gas fees on stake form page (dydxprotocol#731)
DavideSegullo
added a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 28, 2024
fix(staking): update button styling on tokens page + add error if wallet balance < gas fees on stake form page (dydxprotocol#731) chore: another pass for the markets panels padding (dydxprotocol#732) fix(staking): fix chart not loading properly (dydxprotocol#733) fix: back to linear scale orderbook bars (dydxprotocol#734) chore(staking): add default validator as part of stake transaction event (dydxprotocol#736) chore: standardize date/number formatting (dydxprotocol#676) chore(staking): update faq to have see more here link to published help article (dydxprotocol#735) chore: observability for skip migration [OTE-432] (dydxprotocol#737) chore(memo): clean up memo flag + flip staking to be true in mainnet (dydxprotocol#741) feat: add blast and metadata (dydxprotocol#738) Co-authored-by: jaredvu <jaredvu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a helper function version of Output that takes a value and type and returns a string. We can use this in places we are rendering numbers that isn't JSX and ensure we are using the exact same logic for consistency.