Assign duration information so it's available in episode list view wi… #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout starting playback; dyerc#45
GetToSet
reviewed
Aug 13, 2022
Doughnut/Library/Episode.swift
Outdated
| @@ -184,6 +184,11 @@ class Episode: Record { | |||
| pubDate = feedItem.pubDate | |||
| link = feedItem.link | |||
|
|
|||
| let duration = feedItem.iTunes?.iTunesDuration | |||
| if (duration != nil) { | |||
| self.duration = Int(duration!) | |||
There was a problem hiding this comment.
Force unwrapping (! operator) is generally considered as a code smell and should be avoided as possible. A if let statement can be used instead of if (duration != nil) to avoid the force unwrapping.
GetToSet
reviewed
Aug 13, 2022
Doughnut/Library/Episode.swift
Outdated
| @@ -184,6 +184,11 @@ class Episode: Record { | |||
| pubDate = feedItem.pubDate | |||
| link = feedItem.link | |||
|
|
|||
| let duration = feedItem.iTunes?.iTunesDuration | |||
| if (duration != nil) { | |||
There was a problem hiding this comment.
It's generally recommended to omit the parentheses around if conditionals for Swift code.
|
Thank you for the comments, I think it should be better now. I didn't address |
GetToSet
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign duration information so it's available in episode list view without starting playback; #45