Add a playback threshold percentage at which point to mark an episode as played #111
Conversation
| @@ -53,6 +51,18 @@ final class Player: NSObject { | |||
|
|
|||
| private(set) var pausedAt: TimeInterval? = nil | |||
|
|
|||
| var playedThreshold: Double { | |||
| get { | |||
There was a problem hiding this comment.
Swift code generally omits the get keyword for readonly property getters.
SwiftLint has a default rule for this and actually I've planned to enable that in the next version.
| get { | ||
| let prefPercentage = Preference.double(for: Preference.Key.markAsPlayedAfter) | ||
|
|
||
| if prefPercentage <= 100 && prefPercentage >= 50 { |
There was a problem hiding this comment.
It's more common to use , instead of && in if statements.
| @@ -193,6 +203,7 @@ final class Player: NSObject { | |||
|
|
|||
| // Register to receive status events | |||
| avPlayer.addObserver(self, forKeyPath: "status", options: NSKeyValueObservingOptions(rawValue: 0), context: nil) | |||
| NotificationCenter.default.addObserver(self, selector: #selector(playerDidFinishPlaying(notification:)), name: NSNotification.Name.AVPlayerItemDidPlayToEndTime, object: avPlayer) | |||
There was a problem hiding this comment.
With some testing it seems that the notification is not firing when playing to the end. According to this SO thread, the object should be player.currentItem instead of the player itself.
I think there's no need to cleanup player states when played to the end and we'll revisit the behavior when adding the playlist feature. Further, should we set the default threshold to 90% (to match the old behavior) or keep the default value 100%? |
…osition once playback finishes.
I think we can set the new value to 100% because it wasn't shown anywhere that the episode is marked as played after 90%, unless the user looked at the source code. I have left in the Thanks for your testing @GetToSet 👍 |
This PR fixes #106.
@GetToSet would you mind reviewing please. It seemed necessary to have an additional observer event for when the player finishes playback. Do you think we should reset the player visual state at this point? Currently it just stays the same but with 0:00 remaining on the clock (as it always has done). Nothing necessarily short-term, but it was something that occurred to me.