Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly respond to theme changes and some refinements to detail page styles. #78

Merged
merged 14 commits into from
May 24, 2022
Merged

Properly respond to theme changes and some refinements to detail page styles. #78

merged 14 commits into from
May 24, 2022

Conversation

GetToSet
Copy link
Collaborator

@GetToSet GetToSet commented Apr 10, 2022 •
edited

This PR contains:

  1. Properly respond to theme changes between light and dark appearance.
  2. Some styling changes achieve a relatively nice look for detail pages.
    1. Move margins around WKWebView inside the web page so that the scroll bar snaps the window edge.
    2. Use proper margins for lists.
    3. Slightly adjusts the separator line color and use the theme color for links.
    4. Stripe all custom styles by default. This ensures contents are readable, especially in dark mode. Future versions will add an option to view the page with the original style.

⚠️ This PR is based on #74.

@GetToSet
Various project related changes.
482a5b0 
- Put dsa_pub.pem back.
- Reorganize resource files in the project.
@GetToSet
Fix typo and indentations.
fefb096
@GetToSet
Use SwiftLint to check swift file headers.
9bd4bde
@GetToSet
Bump bundle version as timestamp for Release Builds.
fccaddf
@GetToSet
Add trace SQL and web inspector debug options.
f516f91
@GetToSet
Fix a issue that window being accessed in background thread.
4741b77
@GetToSet
Fix a layout issusue on the header of DetailViewController.
e2ed0f7
@GetToSet
Select first item when no previous selected item available after reload.
b168beb
@GetToSet
Fix a potential crash if PLCrashReporter failed to initialize.
c3bca40
@GetToSet
Sort podcasts that have no episodes as least recently updated.
93df453
@GetToSet
Fix improper window title after entering or leaving fullscreen.
9de1637
@GetToSet
Fix a textView height issue for EpisodeInfo view.
809970a
@GetToSet
Properly respond to theme changes.
f7332a3
@GetToSet
Styling refinements for detail pages.
44afcb4
@GetToSet GetToSet force-pushed the ethanwong/darkmode-auto-switch branch from dd6edb7 to 44afcb4 Compare May 19, 2022 14:24
@dyerc dyerc merged commit 2adcaa0 into dyerc:master May 24, 2022
@GetToSet GetToSet deleted the ethanwong/darkmode-auto-switch branch May 25, 2022 03:38
@GetToSet GetToSet added this to the v2.0.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GetToSet @dyerc