Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom User-Agent for media playback #92

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

GetToSet
Copy link
Collaborator

@GetToSet GetToSet commented Jul 11, 2022

Closes #87.

As discussed in #87, this PR implements an identifiable User-Agent for media playback.

Checklist:

  • Compatibility test on macOS Catalina & Big Sur.

After merging this PR, user agent patterns should be submitted to opawg/user-agents and opawg/podcast-rss-useragents. Simple regex patterns like Doughnut should be enough to distinguish Doughnut from other clients.

@GetToSet GetToSet changed the title Implement custom User-Agent for media playback. Implement custom User-Agent for media playback Aug 11, 2022
@GetToSet GetToSet added this to the v2.0.1 milestone Aug 17, 2022
@dyerc dyerc merged commit d577b89 into dyerc:master Oct 11, 2022
@GetToSet GetToSet deleted the ethanwong/player-user-agent branch October 12, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion about the user agent of Doughnut.
2 participants