Fix empty <stack-vector> computations #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that emits the local definition for <stack-vector-temporary> values in an IEP function prefix already prevented emitting an allocation when the stack-allocated vector was empty, but the initialization and reference code did not handle this case properly. * sources/dfmc/llvm-back-end/llvm-emit-computation.dylan (emit-reference on <stack-vector-temporary>): Emit references to empty <stack-vector> results as references to the canoncial empty vector. (emit-computation on <stack-vector>): Don't attempt to reference the <stack-vector-temporary> for an empty stack vector since it wasn't defined.
cgay
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1490.