Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty <stack-vector> computations #1492

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Fix empty <stack-vector> computations #1492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 16 additions & 9 deletions sources/dfmc/llvm-back-end/llvm-emit-computation.dylan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,12 @@ end function;
define method emit-reference
(back-end :: <llvm-back-end>, m :: <llvm-module>, o :: <stack-vector-temporary>)
=> (reference :: <llvm-value>);
ins--bitcast(back-end, temporary-value(o), $llvm-object-pointer-type)
if (o.number-values ~= 0)
ins--bitcast(back-end, temporary-value(o), $llvm-object-pointer-type)
else
// Return the canonical empty vector
emit-reference(back-end, m, dylan-value(#"%empty-vector"))
end if
end method;

// Local temporary definitions
Expand Down Expand Up @@ -1080,14 +1085,16 @@ end method;

define method emit-computation
(back-end :: <llvm-back-end>, m :: <llvm-module>, c :: <stack-vector>) => ()
let word-size = back-end-word-size(back-end);
let class :: <&class> = dylan-value(#"<simple-object-vector>");
let tmp = temporary-value(c.temporary);
for (argument in c.arguments, i from 0)
let ptr = op--getslotptr(back-end, tmp, class, #"vector-element", i);
ins--store(back-end, emit-reference(back-end, m, argument), ptr,
alignment: word-size);
end for;
unless (c.arguments.empty?)
let word-size = back-end-word-size(back-end);
let class :: <&class> = dylan-value(#"<simple-object-vector>");
let tmp = temporary-value(c.temporary);
for (argument in c.arguments, i from 0)
let ptr = op--getslotptr(back-end, tmp, class, #"vector-element", i);
ins--store(back-end, emit-reference(back-end, m, argument), ptr,
alignment: word-size);
end for;
end unless;
end method;

define method repeated-slot-type-alignment
Expand Down