Rename expected-to-fail? to expected-to-fail-test #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housel
reviewed
Mar 13, 2022
| fail. Normally it should reference a bug (a URL or at least a bug number). | ||
| If *expected-to-fail-reason* is supplied, *expected-to-fail?* may be | ||
| omitted because it is implied to be ``#t``. | ||
| *expected-to-fail?*, if supplied, is a function of no arguments that returns |
There was a problem hiding this comment.
Why not call it expected-to-fail-test then?
There was a problem hiding this comment.
SGTM. Will update with that.
There was a problem hiding this comment.
I rebased this onto my github-ci branch because I needed to have the used libraries submoduled in.
cgay
force-pushed
the
doc
branch
2 times, most recently
from
36d4f2c
to
033b06e
Compare
This option is easy to misuse, like this: `expected-to-fail?: $os-name == #"win32"` so I tried to make it clearer that the value should always be a function.
cgay
changed the title
housel
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename expected-to-fail? to expected-to-fail-test
This option is easy to misuse, like this:
expected-to-fail?: $os-name == #"win32"so I tried to make it clearer that the value should always be a function.