This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add detection for Termux terminal #1923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Termux sets the TERMUX_VERSION environment variable.
Catches something like running xfce4-terminal in an X server
|
Changed the Termux detection to be after the PPID check. Termux doesn't show its own PID, so this catches an x11 terminal running off Termux. |
Open
hykilpikonna
approved these changes
Jul 31, 2022
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Jul 31, 2022
…inal Upstream PR: dylanaraps#1923 Thanks to @easyaspi314 Co-authored-by: easyaspi314 (Devin) <easyaspi314@users.noreply.github.com>
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Jul 31, 2022
|
This shows the terminal as "com.termux" for termux 0.118... I fixed it by adding a special check
|
|
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds detection for Termux (Termux sets the
$TERMUX_VERSIONenvironment variable, but doesn't expose its PID).