This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
neofetch: Print MACHINE_ARCH not MACHINE for FreeBSD #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MACHINE refers to the architecture family, whereas MACHINE_ARCH refers to the specific variant. For x86, MACHINE is already split up into i386 and amd64, so there is only one MACHINE_ARCH for each, that takes an identical value, and thus this patch has no effect there. There is also the oddity of arm64, which only has one MACHINE_ARCH, but the name of that is aarch64. For other architectures, one MACHINE covers multiple MACHINE_ARCH variants, like powerpc which has powerpc, powerpcspe, powerpc64 and powerpc64le. It's therefore more helpful to print MACHINE_ARCH here, not MACHINE. Note that MACHINE_ARCH is what official release information, such as download pages and the list of supported architectures, tends to use, due to its increased specificity. This may also apply to other BSDs, but I have no experience of them.
hykilpikonna
approved these changes
Jul 31, 2022
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Jul 31, 2022
…ACHINE for FreeBSD Upstream PR: dylanaraps#2015 Thanks to @jrtc27 Co-authored-by: Jessica Clarke <jrtc27@jrtc27.com>
|
Maybe a better way of writing it would be to test for |
|
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MACHINE refers to the architecture family, whereas MACHINE_ARCH refers
to the specific variant. For x86, MACHINE is already split up into i386
and amd64, so there is only one MACHINE_ARCH for each, that takes an
identical value, and thus this patch has no effect there. There is also
the oddity of arm64, which only has one MACHINE_ARCH, but the name of
that is aarch64. For other architectures, one MACHINE covers multiple
MACHINE_ARCH variants, like powerpc which has powerpc, powerpcspe,
powerpc64 and powerpc64le. It's therefore more helpful to print
MACHINE_ARCH here, not MACHINE.
Note that MACHINE_ARCH is what official release information, such as
download pages and the list of supported architectures, tends to use,
due to its increased specificity.
This may also apply to other BSDs, but I have no experience of them.