This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
BUGFIX: fix offset bug w/ col_offset and many color blocks #2037 #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelofallars
changed the title
|
Great that you were able to send in a fix for this! |
hykilpikonna
approved these changes
Jul 31, 2022
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Jul 31, 2022
…ol_offset and many color blocks dylanaraps#2037 Upstream PR: dylanaraps#2042 Thanks to @angelofallars Co-authored-by: Angelo Fallaria <ba.fallaria@gmail.com>
|
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info! |
|
I've also merged it into the alignment branch of my fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2037
Fix a bug where
neofetchwas passed a numericcol_offsetvalue and the program only set the offset of the first color block, but not the others.The first block either used the
text_paddingoffset or the number set incol_offset. However, the other blocks still usedtext_paddingeven ifcol_offsetwas specified a number.Original (
--col_offset 60):Fixed (
--col_offset 60):Features
Issues
TODO