This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
GPU: Print each GPU on a different line #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works!
For some reason, battery subtitle seems to be broke, though. |
|
Is the battery subtitle broken in master? |
|
Yep, seems to be broken in master too. |
|
Fixed. |
konimex
reviewed
Dec 22, 2016
| gpu="${gpu/Intel }" | ||
| fi | ||
|
|
||
| prin "GPU${gpu_num}" "$gpu" |
There was a problem hiding this comment.
You may want to change the GPU one into ${subtitle}, like the battery function.
|
Also, it seems we're still printing the results starting from |
|
Sure, easy fix. :) |
|
I've added |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
get_gpu()display each GPU on a separate line on Linux systems.Features
Issues
TODO
all,dedicatedorintegrated.CC @konimex,, can you test this?