Signature verification #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids 'Nothings' and the Monoid can never inject keys from the signature itself.
This test does no longer work, since the behavior changed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the following flaw in the SAML signature verification process.
hsaml2 maintains a pair of an optional RSA and an optional DSA key.
It may be used under the assumption that one could pass hsam2 an RSA key and an empty slot for the DSA key.
However, this has the effect that the DSA key from the signature itself will be added to the pair of trusted keys.
DSA has precedence over RSA, so the signature validation will be successful if (and only if) one provides a DSA public key matching her own signature.