Include the real name for the user list

[victori]

Had a request to add real names on the user-list. Makes sense for certain teams.

[EionRobb]

Just use g_strdup_printf() instead of dodgy mallocs

[victori]

Eion, Thanks for the suggestion, as you can tell I don’t do any C/C++ development. Just Java, Ruby, Python and friends. - Victor

…

On May 25, 2018, at 4:11 PM, Eion Robb ***@***.***> wrote: @EionRobb requested changes on this pull request. Just use g_strdup_printf() instead of dodgy mallocs — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[EionRobb]

Oh, in that case in future, never mix code that works with bytes (malloc, sprintf) with code that works with characters (g_utf8_strlen)
What you currently have there will try to allocate less memory than needed, (eg 40 chinese characters == 80 bytes) and then try to write all the memory not not enough space, overflowing the memory and if you're lucky it will only crash the app, but otherwise will overwrite memory of data around it causing all kinds of chaos :)

[xypd]

overflowing the memory and if you're lucky it will only crash the app

Funny, not sure if this was my issue ... but Adium did crash when I tried sending a message to a contact. Probably should have reported it.

[victori]

Hmm, I tried it but it kept segfaulting. victori@fd6d659 - Victor

…

On May 25, 2018, at 5:02 PM, Eion Robb ***@***.***> wrote: Oh, in that case in future, never mix code that works with bytes (malloc, sprintf) with code that works with characters (g_utf8_strlen) What you currently have there will try to allocate less memory than needed, (eg 40 chinese characters == 80 bytes) and then try to write all the memory not not enough space, overflowing the memory and if you're lucky it will only crash the app, but otherwise will overwrite memory of data around it causing all kinds of chaos :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[dylex]

There do not seem to be any changes left here. Closing.