Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductPage - Image Captions #113

Closed
jsirish opened this issue Jun 20, 2014 · 2 comments
Closed

ProductPage - Image Captions #113

jsirish opened this issue Jun 20, 2014 · 2 comments
Milestone

Comments

@jsirish
Copy link
Member

jsirish commented Jun 20, 2014

Allow a caption to be entered for each product image. Would be nice to add a reference to a product option, for example

@jsirish jsirish added this to the 1.1 milestone Jun 20, 2014
@jsirish jsirish changed the title ProductPage -Image Captions ProductPage - Image Captions Jun 20, 2014
@jsirish
Copy link
Member Author

jsirish commented Jan 24, 2015

Looked at this today. Because we have a has_many ProductImage from Product, ProductImage already has a 'Title' field. This could be referenced in the template as a caption.

For PreviewImage, we just reference the Image class. Image does have a Title field as well, which could be leveraged as a caption. It's not super intuitive in the UploadField to set the Title, however.

@muskie9
Copy link
Member

muskie9 commented Jan 25, 2015

Should the PreviewImage be included in the flexslider? If the image is used as the preview it may be sized smaller than the flexslider area/overlay. This would also alleviate the need for a a description on the PreviewImage.

@muskie9 muskie9 added the 1.0 label Jan 29, 2015
muskie9 added a commit to muskie9/FoxyStripe that referenced this issue Feb 13, 2015
Update FlexSlider.ss include to show either ProductImages (if they exist) or PreviewImage.

fixes dynamic#113
muskie9 added a commit to muskie9/FoxyStripe that referenced this issue Feb 13, 2015
Update FlexSlider.ss include to show either ProductImages (if they exist) or PreviewImage.

fixes dynamic#113
muskie9 added a commit to muskie9/FoxyStripe that referenced this issue Feb 13, 2015
Update FlexSlider.ss include to show either ProductImages (if they exist) or PreviewImage.

fixes dynamic#113
muskie9 added a commit to muskie9/FoxyStripe that referenced this issue Feb 13, 2015
Update FlexSlider.ss include to show either ProductImages (if they exist) or PreviewImage.

fixes dynamic#113
@muskie9 muskie9 closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants