Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - force ProductCategory Code to be unique #371

Merged
merged 3 commits into from Dec 5, 2018

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Dec 4, 2018

fixes #339

@jsirish jsirish requested a review from muskie9 December 4, 2018 05:15
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #371 into master will decrease coverage by 0.07%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #371      +/-   ##
============================================
- Coverage     29.04%   28.97%   -0.08%     
- Complexity      437      439       +2     
============================================
  Files            28       28              
  Lines          1821     1826       +5     
============================================
  Hits            529      529              
- Misses         1292     1297       +5
Impacted Files Coverage Δ Complexity Δ
src/Model/ProductCategory.php 85.84% <16.66%> (-3.98%) 22 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd82bd...f514262. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #371 into master will decrease coverage by 0.07%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #371      +/-   ##
============================================
- Coverage     29.04%   28.97%   -0.08%     
- Complexity      437      439       +2     
============================================
  Files            28       28              
  Lines          1821     1826       +5     
============================================
  Hits            529      529              
- Misses         1292     1297       +5
Impacted Files Coverage Δ Complexity Δ
src/Model/ProductCategory.php 85.84% <16.66%> (-3.98%) 22 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd82bd...a8025f4. Read the comment docs.

@jsirish jsirish merged commit 1a1c218 into dynamic:master Dec 5, 2018
@jsirish jsirish deleted the bugfix/uniqueCategoryCode branch December 5, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProductCategory - should not be able to add duplicate codes, currently allowed
1 participant