Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/ss4 #3

Merged
merged 14 commits into from
Oct 18, 2017
Merged

Refactor/ss4 #3

merged 14 commits into from
Oct 18, 2017

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Oct 18, 2017

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2017

Codecov Report

Merging #3 into master will decrease coverage by 26.35%.
The diff coverage is 61.38%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master       #3       +/-   ##
=============================================
- Coverage       100%   73.64%   -26.36%     
- Complexity        0       45       +45     
=============================================
  Files             4        7        +3     
  Lines            72      148       +76     
=============================================
+ Hits             72      109       +37     
- Misses            0       39       +39
Impacted Files Coverage Δ Complexity Δ
src/Elements/DynamicBaseElement.php 100% <100%> (ø) 9 <4> (?)
src/Elements/SectionElement.php 100% <100%> (ø) 1 <0> (?)
.../Extensions/SlideshowElementSlideDataExtension.php 100% <100%> (ø) 1 <1> (?)
src/Elements/AccordionElement.php 100% <100%> (ø) 2 <0> (?)
src/Model/AccordionPanel.php 100% <100%> (ø) 8 <4> (?)
src/Elements/PromosElement.php 34.04% <34.04%> (ø) 14 <14> (?)
src/Model/PromoObject.php 76.47% <76.47%> (ø) 10 <10> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d970e...0d710ca. Read the comment docs.

@jsirish jsirish merged commit a6e3563 into dynamic:master Oct 18, 2017
@jsirish jsirish deleted the refactor/ss4 branch October 18, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant