Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elements and objects that have images now own them #47

Merged
merged 1 commit into from
Jan 4, 2018
Merged

elements and objects that have images now own them #47

merged 1 commit into from
Jan 4, 2018

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Jan 4, 2018

  - so images get published when they do
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #47 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
- Coverage     82.48%   82.41%   -0.07%     
  Complexity       77       77              
============================================
  Files            18       18              
  Lines           274      273       -1     
============================================
- Hits            226      225       -1     
  Misses           48       48
Impacted Files Coverage Δ Complexity Δ
src/Model/BaseElementObject.php 100% <ø> (ø) 3 <0> (ø) ⬇️
src/Elements/ElementHero.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Elements/ElementImage.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Model/GalleryImage.php 100% <100%> (ø) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59b6e1...ce8efe5. Read the comment docs.

@mak001 mak001 merged commit 1080cf4 into dynamic:master Jan 4, 2018
@mak001 mak001 deleted the owns-image branch January 4, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant