Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - remove ElementEmailSignup #76

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Mar 24, 2018

functions can be handled by ElementEmbeddedCode

functions can be handled by `ElementEmbeddedCode`
@jsirish jsirish requested review from muskie9 and mak001 March 24, 2018 22:50
@codecov
Copy link

codecov bot commented Mar 24, 2018

Codecov Report

Merging #76 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
- Coverage     96.92%   96.81%   -0.11%     
+ Complexity       63       61       -2     
============================================
  Files            24       23       -1     
  Lines           293      283      -10     
============================================
- Hits            284      274      -10     
  Misses            9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ceb0f7...6214f76. Read the comment docs.

@jsirish jsirish merged commit a6597dd into dynamic:master Mar 27, 2018
@jsirish jsirish deleted the refactor/removeEmailSignup branch March 27, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant