Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config file format from dict based to list based #59

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

Grokzen
Copy link
Collaborator

@Grokzen Grokzen commented Aug 23, 2023

Fixed #49

…ith repo_name: repo_data, it is now an ordered list where the name is moved inside the repo_data.

This change is breaking and no backwards compatibility will be provided. Next major release will start using this format and the old format will only be supported up to 0.3.0 release
@Grokzen Grokzen requested a review from holmboe August 23, 2023 17:53
@Grokzen Grokzen self-assigned this Aug 23, 2023
Copy link
Contributor

@holmboe holmboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (1 minor comment)

subgit/core.py Outdated
@@ -439,7 +451,8 @@ def pull(self, names):
# branch or where the origin HEAD is pointing to. After we clone we can then move our
# repo to the correct revision we want.
repo = Repo.clone_from(
config["repos"][name]["url"],
# config["repos"][name]["url"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code?

subgit/core.py Outdated Show resolved Hide resolved
@Grokzen Grokzen merged commit 52cd64c into master Aug 24, 2023
@Grokzen Grokzen deleted the f/list-based-config-file branch August 24, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change config format from dict to list of projects
2 participants