fix type test fails caused by strict: true

dynamoose · Apr 25, 2024 · 6859485 · 6859485
1 parent e17bcdd
commit 6859485
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 10 deletions.
diff --git a/packages/dynamoose/test/types/Model.ts b/packages/dynamoose/test/types/Model.ts
@@ -74,9 +74,9 @@ const shouldFailWithInvalidConditionTransaction = model.transaction.condition(0,
 
 // Typed Models
 export class User extends Item {
-	id: string;
-	name: string;
-	age: number;
+	id!: string;
+	name!: string;
+	age!: number;
 }
 const userSchema = new dynamoose.Schema({
 	"id": String,
@@ -108,5 +108,5 @@ UserTypedModel.update({"id": "foo"}, {
 });
 
 UserTypedModel.update({"id": "foo"}, {
-	"$REMOVE":{"age":null}
+	"$REMOVE":{"age":undefined}
 });
diff --git a/packages/dynamoose/test/types/Schema.ts b/packages/dynamoose/test/types/Schema.ts
@@ -107,7 +107,7 @@ const shouldSucceedWithAsyncSetMethodSchema = new dynamoose.Schema({
 const shouldSucceedWithSetMethodSecondArgSchema = new dynamoose.Schema({
 	"id": {
 		"type": String,
-		"set": (value, oldValue) => oldValue
+		"set": (value, oldValue) => oldValue ? oldValue : value
 	}
 });
 const shouldSucceedWithAsyncValidateMethodSchema = new dynamoose.Schema({

diff --git a/packages/dynamoose/test/types/model/Query.ts b/packages/dynamoose/test/types/model/Query.ts
@@ -23,9 +23,12 @@ let isAssignableToQuery : Query<User>;
 isAssignableToQuery = UserTypedModel.query("name").eq("Will").limit(5);
 
 // query.startAt(key)
-async function queryStartAt (): Promise<Query<User>> {
+async function queryStartAt (): Promise<Query<User> | undefined> {
 	const response = await UserTypedModel.query("name").eq("Will").exec();
-	return UserTypedModel.query("name").eq("Will").startAt(response.lastKey);
+
+	if (response.lastKey) {
+		return UserTypedModel.query("name").eq("Will").startAt(response.lastKey);
+	}
 }
 
 // query.attributes(attributes)

diff --git a/packages/dynamoose/test/types/model/Scan.ts b/packages/dynamoose/test/types/model/Scan.ts
@@ -25,9 +25,11 @@ let isAssignableToScan : Scan<User>;
 isAssignableToScan = UserTypedModel.scan().limit(5);
 
 // scan.startAt(key)
-async function scanStartAt (): Promise<Scan<User>> {
+async function scanStartAt (): Promise<Scan<User> | undefined> {
 	const response = await UserTypedModel.scan().exec();
-	return UserTypedModel.scan().startAt(response.lastKey);
+	if (response.lastKey) {
+		return UserTypedModel.scan().startAt(response.lastKey);
+	}
 }
 
 // scan.attributes(attributes)

diff --git a/packages/dynamoose/test/types/tsconfig.json b/packages/dynamoose/test/types/tsconfig.json
@@ -6,6 +6,6 @@
 		"target": "es2017",
 		"noEmit": true,
 		"strict": true
-	},
+},
 	"include": ["./**/*"]
 }