Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inputs types for Mode.update() #1599

Merged
merged 1 commit into from
May 7, 2023
Merged

Fixed inputs types for Mode.update() #1599

merged 1 commit into from
May 7, 2023

Conversation

lmanerich
Copy link
Contributor

Summary:

Sending the rebased branch and applying the commits from #1379 to fix #1044 and #1209 as the previous PR seems to be abandoned.

GitHub linked issue:

#1044
#1209

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #---- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 🚨 YES 🚨
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have read through and followed the Contributing Guidelines
  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have filled out all fields above

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lmanerich
Copy link
Contributor Author

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@fishcharlie fishcharlie merged commit 19538da into dynamoose:main May 7, 2023
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] '$SET' does not exist in type 'Partial<Model>'
2 participants