Fix global index deletion when projection type is INCLUDE

[madhusudhand]

Summary:

Fixes issue where index is deleted when projection is set to list of attributes instead of ALL.

Code sample:

Schema

const schema = new dynamoose.Schema(
    {
      id: {
        type: String,
        required: true,
        hashKey: true,
      },
      group: {
        type: String,
        required: true,
        index: {
            name: 'group-gsi',
            type: 'global',
            project: ['data1', 'data3', 'data2'],
        }
     },
     data1: String,
     data2: String,
     data3: String
);

Model

dynamoose.model('TableName', schema, {
  create: true,
  update: true,
});

GitHub linked issue:

Closes #1603

Type (select 1):

• Bug fix
• Feature implementation
• Documentation improvement
• Testing improvement

• Test added to report bug (GitHub issue #---- @---)
• Something not listed here

Is this a breaking change? (select 1):

• 🚨 YES 🚨
• No
• I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

• Yes
• No

Are all the tests currently passing on this PR? (select 1):

• Yes
• No

Other:

• I have read through and followed the Contributing Guidelines
• I have searched through the GitHub pull requests to ensure this PR has not already been submitted
• I have updated the Dynamoose documentation (if required) given the changes I made
• I have added/updated the Dynamoose test cases (if required) given the changes I made
• I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
• All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
• I have filled out all fields above

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[madhusudhand]

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

[github-actions]

This pull request is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

[madhusudhand]

Hey can you reopen and review this?

[madhusudhand]

Hi, could you review and merge this change?
without this I cannot use indexes with specific projection list

[madhusudhand]

@fishcharlie Could you please review this change and bring it in?

[madhusudhand]

@fishcharlie can you consider merging this?

[fishcharlie]

@madhusudhand Sorry for the delay on this. Thank you for continuing to politely pester me.