Remove: unused 2 line in "moveCamera" #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the way, I add pinch&zoom into "place".I didn't use interact.js. I tried, but it doesn't work very well. final solution look something like this: (check my comment) I may send a PR a couple days later from now. feel free to merge or reject. all fine by me |
|
it's been too long, so I just close it myself |
|
canvas.place is a side project for all of us, and as such we cannot review pull requests instantly. We attempt to do it as soon as we are able. |
|
@nullpixel understandable, I am not complaining :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small PR
Only remove 2 line of code.
Because Visual Studio show these 2 line are not used.
it didn't effect any logic