Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Chart Range: Gets destroyed on click when no timestamp is present #100

Closed
ffriedl89 opened this issue Nov 13, 2019 · 3 comments · Fixed by #517
Closed

Chart Range: Gets destroyed on click when no timestamp is present #100

ffriedl89 opened this issue Nov 13, 2019 · 3 comments · Fixed by #517
Assignees
@lukasholzer
Labels
bug A broken behaviour that was working previously has-pr P1 Urgent issue that should be resolved before the next release

Comments

@ffriedl89
Copy link
Collaborator

If no timestamp is present we should not destroy the range. Filter out the click and ignore it if no timestamp is set
@ffriedl89 ffriedl89 added bug A broken behaviour that was working previously P1 Urgent issue that should be resolved before the next release labels Nov 13, 2019
@lukasholzer lukasholzer self-assigned this Dec 5, 2019
@renepanzar
Copy link
Contributor

Any info on when this will be addressed?

@lukasholzer lukasholzer mentioned this issue Feb 3, 2020
Merged
4 tasks
@lukasholzer
Copy link
Contributor

Any info on when this will be addressed?

Currently working on this bug.
The problem with fixing this bug is that we have to support this behaviour – in the case that a range and a timestamp can be used together this is a valid behaviour because with a click the range it gets destroyed to create a timestamp.

All our logic (event listeners and handling) is based on that there can exist a timestamp and a range so it makes it hard to fix this bug. Will require some rewrites of the core functionality of the selection area.

lukasholzer pushed a commit that referenced this issue Feb 3, 2020
fix(chart): Fixes an issue where the range was destroyed on click.
1a32e55 
Fixes #100. Fixes an issue where the chart selection of a time-frame was destroyed when a click somewhere else in the chart was performed.
lukasholzer pushed a commit that referenced this issue Feb 3, 2020
fix(chart): Fixes an issue where the range was destroyed on click.
14fa302 
Fixes #100. Fixes an issue where the chart selection of a time-frame was destroyed when a click somewhere else in the chart was performed.
@renepanzar
Copy link
Contributor

@lukasholzer, thanks for the heads-up!

lukasholzer pushed a commit that referenced this issue Feb 4, 2020
@lukasholzer
fix(chart): Fixes an issue where the range was destroyed on click.
851624f 
Fixes #100. Fixes an issue where the chart selection of a time-frame was destroyed when a click somewhere else in the chart was performed.
github-actions bot pushed a commit that referenced this issue Feb 4, 2020
@lukasholzer
fix(chart): Fixes an issue where the range was destroyed on click.
a941b12 
Fixes #100. Fixes an issue where the chart selection of a time-frame was destroyed when a click somewhere else in the chart was performed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lukasholzer lukasholzer

Labels
bug A broken behaviour that was working previously has-pr P1 Urgent issue that should be resolved before the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes an issue where the range was destroyed on click dynatrace-oss/barista
3 participants
@ffriedl89 @lukasholzer @renepanzar