This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Add option to disable Dynatrace metadata enrichment #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirgeo
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
In all the other implementations I think we have this the other way around, as in: The toggle is called EnrichWithOneAgentMetadata and the default value is true. I am not strongly for or against one way or the other, and I am not sure how complicated it is in Go to use a default value different than the actual default of the primitive, so I am leaving this decision open to you.
arminru
changed the title
arminru
approved these changes
Jul 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is to disable because in go there is no way to tell the difference between unset and false.