Remove VLA from d90stairsteppingfix

dyne · Dec 28, 2022 · 0e9ba7a · 0e9ba7a
1 parent a4f417d
commit 0e9ba7a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/filter/d90stairsteppingfix/CMakeLists.txt b/src/filter/d90stairsteppingfix/CMakeLists.txt
@@ -1,7 +1,3 @@
-if(MSVC AND NOT CMAKE_CXX_COMPILER_ID MATCHES Clang)
-  return() # MSVC cl doesn't support Variable Length Arrays (VLA), but clang-cl does
-endif()
-
 set (SOURCES d90stairsteppingfix.cpp)
 set (TARGET d90stairsteppingfix)
 

diff --git a/src/filter/d90stairsteppingfix/d90stairsteppingfix.cpp b/src/filter/d90stairsteppingfix/d90stairsteppingfix.cpp
@@ -135,7 +135,7 @@ class D90StairsteppingFix : public frei0r::filter
              * and therefore get the number (line1+line2)/2, here 6.5.
              * This positions will later be used for interpolation.
              */
-            float filled[newHeight];
+            float *filled = (float *) malloc(newHeight * sizeof(float));
 
             int count = 0;
             int index = 0;
@@ -160,7 +160,7 @@ class D90StairsteppingFix : public frei0r::filter
              * Calculate scaling numbers to scale the full height matrix
              * with the slice lines down to the original height (720p).
              */
-            float downScaling[height];
+            float *downScaling = (float *) malloc(height * sizeof(float));
 
             float scaleFactor = (float) newHeight/height;
 //          printf("scale factor: %f\n", scaleFactor);
@@ -184,6 +184,9 @@ class D90StairsteppingFix : public frei0r::filter
                 m_mesh[i] = (1-offset)*filled[index] + offset*filled[index+1];
 //              printf("%f at %d with weights %f and %f\n", m_mesh[i], i, (1-offset)*downScaling[i], offset*downScaling[i+1]);
             }
+
+            free(downScaling);
+            free(filled);
 
         } else {
             // Not a 720p file.